Not receiving notifications on some posts
Moderator: Moderators
- Tcg
- Savant
- Posts: 8521
- Joined: Tue Nov 21, 2017 5:01 am
- Location: Third Stone
- Has thanked: 2159 times
- Been thanked: 2300 times
Not receiving notifications on some posts
Post #1I'm not receiving notifications on some posts. This seems to be limited to replies that don't include a quotation. I'm not sure if others are seeing this or if it is related to something specific about my account settings or setup in general.
- Tcg
- Savant
- Posts: 8521
- Joined: Tue Nov 21, 2017 5:01 am
- Location: Third Stone
- Has thanked: 2159 times
- Been thanked: 2300 times
Re: Not receiving notifications on some posts
Post #21Nothing.Difflugia wrote: ↑Mon Jul 12, 2021 12:57 pm [Replying to Tcg in post #11]
Response #8
"'Post reply' button, non-empty quote tag."
- Difflugia
- Prodigy
- Posts: 3085
- Joined: Wed Jun 12, 2019 10:25 am
- Location: Michigan
- Has thanked: 3347 times
- Been thanked: 2049 times
Re: Not receiving notifications on some posts
Post #22[Replying to Tcg in post #11]
"'Post reply' button, non-empty, alphanumeric response in quote tag."
Response #9
"'Post reply' button, non-empty, alphanumeric response in quote tag."
My pronouns are he, him, and his.
- Difflugia
- Prodigy
- Posts: 3085
- Joined: Wed Jun 12, 2019 10:25 am
- Location: Michigan
- Has thanked: 3347 times
- Been thanked: 2049 times
Re: Not receiving notifications on some posts
Post #23There's a regular expression search on line 234 of phpBB3/includes/bbcode.php in the current code from the website (3.3.4) that matches a quotation with user ID. I'm betting that's the one used to send the notification.
My pronouns are he, him, and his.
- Tcg
- Savant
- Posts: 8521
- Joined: Tue Nov 21, 2017 5:01 am
- Location: Third Stone
- Has thanked: 2159 times
- Been thanked: 2300 times
Re: Not receiving notifications on some posts
Post #24Nothing.Difflugia wrote: ↑Mon Jul 12, 2021 1:02 pm [Replying to Tcg in post #11]
Response #9
"'Post reply' button, non-empty, alphanumeric response in quote tag."
- Difflugia
- Prodigy
- Posts: 3085
- Joined: Wed Jun 12, 2019 10:25 am
- Location: Michigan
- Has thanked: 3347 times
- Been thanked: 2049 times
Re: Not receiving notifications on some posts
Post #25That's weird. I expected that one to work and was already assuming that it had.
My pronouns are he, him, and his.
- Tcg
- Savant
- Posts: 8521
- Joined: Tue Nov 21, 2017 5:01 am
- Location: Third Stone
- Has thanked: 2159 times
- Been thanked: 2300 times
Re: Not receiving notifications on some posts
Post #26I double checked it. No notification. You can try again in case I missed something.
- Difflugia
- Prodigy
- Posts: 3085
- Joined: Wed Jun 12, 2019 10:25 am
- Location: Michigan
- Has thanked: 3347 times
- Been thanked: 2049 times
Re: Not receiving notifications on some posts
Post #27Scratch that. It looks like the posts are stored in the database as XML documents. There's a function called "get_outermost_quote_authors" in phpBB3/phpbb/textformatter/s9e/utils.php that finds quoted authors in a XML document. It looks like it's only called by "find_users_for_notification" in phpBB3/phpbb/notification/type/quote.php. It's probably safe to change get_outermost_quote_authors, but I'm looking a little closer to try and figure out how it works.
My pronouns are he, him, and his.
- Difflugia
- Prodigy
- Posts: 3085
- Joined: Wed Jun 12, 2019 10:25 am
- Location: Michigan
- Has thanked: 3347 times
- Been thanked: 2049 times
Re: Not receiving notifications on some posts
Post #28I think if you add this to get_outermost_quote_authors in phpBB3/phpbb/textformatter/s9e/utils.php (or create a second function and make it a plugin or whatever; I don't know anything about your style), it will notify for the reply button. If you make a second function, it's called in find_users_for_notification in phpBB3/phpbb/notification/type/quote.php. I haven't tested it and it's based on a few guesses about how things work, but I'm optimistic.
Code: Select all
foreach ($xpath->query('//URL[not(ancestor::QUOTE)]') as $url_text)
{
if (preg_match('/Replying to (.+)/', $url_text, $match))
{
$end_of_uname = strrpos($match[1], ' in post #', 0)
if($end_of_uname !== false)
{
$authors[] = substr($match[1], 0, -$end_of_uname)
}
}
}
My pronouns are he, him, and his.
- otseng
- Savant
- Posts: 20593
- Joined: Thu Jan 15, 2004 1:16 pm
- Location: Atlanta, GA
- Has thanked: 197 times
- Been thanked: 337 times
- Contact:
Re: Not receiving notifications on some posts
Post #29[Replying to Difflugia in post #29]
Thanks and added your code. Hopefully you'll get notified by this post.
Thanks and added your code. Hopefully you'll get notified by this post.